New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta): Fix tags behavior to reflect the documentation #903

Open

carl-baillargeon wants to merge 2 commits into aristanetworks:main from carl-baillargeon:fix/tags_again

Contributor

carl-baillargeon commented Oct 28, 2024

Description

#827 fixed multiple --tags CLI support but introduced an issue where test-to-device tag matching wasn't properly enforced.

This PR now reflects the behavior specified in the Tag Management documentation.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)


          fix(anta): Fix tags behavior

c6e6a39

github-actions bot assigned carl-baillargeon


          Use total_test_count for better performance

26448db

sonarcloud bot commented Oct 28, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codspeed-hq bot commented Oct 28, 2024 •

edited

Loading

CodSpeed Performance Report

Merging #903 will not alter performance

_{Comparing carl-baillargeon:fix/tags_again (26448db) with main (a76ae07)}

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet